Fix skip condition of gh13082.phpt #14922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failure is not particularly related to Travis, but rather is caused by the GD font file to only be suitable for platforms where `int` stores 32bit values in little endian byte order. This platform dependence is documented in the source code[1]. Thus we fix the skip condition and skip reason accordingly. An alternative would be to dynamically create the font file just before running the test, but that appears to be overkill. [1] <https://github.com/php/php-src/blob/d59691c02fa77b65855ebbcd5f50aaac034ab75d/ext/gd/gd.c#L545-L556>
| @@ -3,7 +3,7 @@ GH-13082 - imagefontwidth/height unexpectedly throwing an exception on a valid G | |||
| --EXTENSIONS-- | |||
| gd | |||
| --SKIPIF-- | |||
| <?php if (getenv('TRAVIS')) die('skip Currently fails on Travis'); ?> | |||
| <?php if (pack('i', 0x01020304) !== "\x04\x03\x02\x01") die('skip unsupported platform'); ?> | |||
There was a problem hiding this comment.
It might be better to be clear about "what" the platform does not support.
Suggested change
| <?php if (pack('i', 0x01020304) !== "\x04\x03\x02\x01") die('skip unsupported platform'); ?> | |
| <?php if (pack('i', 0x01020304) !== "\x04\x03\x02\x01") die('skip big endian is unsupported'); ?> |
There was a problem hiding this comment.
Indeed, but it's not only about the endianess, but also int must be 32bit. Maybe the latter is pretty much the case everywhere nowadays, but that might change.
There was a problem hiding this comment.
Ah, I overlooked that. It is impossible to explain this in detail in one sentence.
SakiTakamachi
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failure is not particularly related to Travis, but rather is caused by the GD font file to only be suitable for platforms where
intstores 32bit values in little endian byte order. This platform dependence is documented in the source code[1]. Thus we fix the skip condition and skip reason accordingly.An alternative would be to dynamically create the font file just before running the test, but that appears to be overkill.
[1]
php-src/ext/gd/gd.c
Lines 545 to 556 in d59691c
Note that this is a follow up to #13208.
The skip reason might be improved; I've kept it as short as possible for now.